Repository navigation
Modernize installer dependencies and Node support - #48
Merged
Merged
Conversation
garyb
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modernizes the installer to remove vulnerable dependency paths and run installation and tests without dependency deprecations or engine warnings showing up anymore. To do that, I had to make a couple replacements:
make-fetch-happenwith Undici, retaining proxy support, redirects, retries, and cancellation.rimrafwith native filesystem cleanup andtapwith Node’s built-in test runner.Breaking changes
This now requires Node
^22.22.2 || ^24.15.0 || >=26.0.0because cacache 21 requires these versions; Node 20 is EOL anyway so this seems fine.I'm reusing the changes proposed in #42, and #39 is already superseded by a merged upgrade to
make-fetch-happen, so this replaces both of those changes.The upstream fix in npm/cacache#350 is now released in cacache 21.0.2. Updating to it removes the remaining audit findings while retaining the existing cache implementation and format.That merged, so we're now warning-free.